fix: restore BuiltBy=goreleaser ldflag in GoReleaser configs#27
Merged
miguelsanchez-upsun merged 1 commit intomainfrom Mar 12, 2026
Merged
fix: restore BuiltBy=goreleaser ldflag in GoReleaser configs#27miguelsanchez-upsun merged 1 commit intomainfrom
miguelsanchez-upsun merged 1 commit intomainfrom
Conversation
The BuiltBy ldflag was removed in 73a97c7 when switching to runtime/debug for version info. Unlike Version, Commit, and Date, BuiltBy has no source in runtime/debug and needs an explicit ldflag. Without it, GoReleaser-built binaries incorrectly report "built ... by local". Closes [CLI-115: Restore BuiltBy=goreleaser ldflag in GoReleaser config](https://linear.app/platformsh/issue/CLI-115/restore-builtbygoreleaser-ldflag-in-goreleaser-config) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Restores the BuiltBy=goreleaser Go ldflag in GoReleaser configuration so GoReleaser-built binaries correctly report they were built by “goreleaser” (instead of the default “local”) when version --verbose is used.
Changes:
- Add
-X "github.com/upsun/cli/internal/config.BuiltBy=goreleaser"to all build entries in.goreleaser.yaml. - Add the same ldflag to both build entries in
.goreleaser.vendor.yaml.tpl.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.goreleaser.yaml |
Restores BuiltBy=goreleaser ldflag across all GoReleaser build definitions. |
.goreleaser.vendor.yaml.tpl |
Ensures vendor-template GoReleaser builds also set BuiltBy=goreleaser. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
miguelsanchez-upsun
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-X "...BuiltBy=goreleaser"ldflag that was removed in 73a97c7.goreleaser.yamland both in.goreleaser.vendor.yaml.tpl🤖 Generated with Claude Code